[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8274699: Certain blend modes cannot be set from CSS [v2]
From:       Kevin Rushforth <kcr () openjdk ! java ! net>
Date:       2021-10-29 15:53:14
Message-ID: LngoPHLweiTomw6TRtDNxWOCwIUQXPN_2OV9kAGmT-I=.94f90cb5-fe10-460a-acf1-7734d7339c9e () github ! com
[Download RAW message or body]

On Fri, 29 Oct 2021 15:37:36 GMT, Marius Hanl <mhanl@openjdk.org> wrote:

> > Looks good, although the solution in itself remains fishy. Maybe create a ticket \
> > to implement a better solution in the future?
> 
> yes, the css code is sometimes very ... interesting. I have not looked closely but \
> it's weird that there are converters - which converts the value while its also done \
> here. A cleanup generally is not a bad idea here. That's also visible by the amount \
> of TODOs in the code.

I filed [JDK-8276180](https://bugs.openjdk.java.net/browse/JDK-8276180) to track this \
particular cleanup.

-------------

PR: https://git.openjdk.java.net/jfx/pull/640


[prev in list] [next in list] [prev in thread] [next in thread]