[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Integrated: 8255015: Inconsistent illumination of 3D shape by PointLight
From:       Andreas Heger <duke () openjdk ! java ! net>
Date:       2021-10-29 14:14:25
Message-ID: 01TR8QNYFGrU2AJVLp5dgurxXOQjGcybGr1H_PwDSSo=.25adfc8e-250d-428b-a542-aad82f68800e () github ! com
[Download RAW message or body]

On Wed, 9 Jun 2021 18:22:31 GMT, Andreas Heger <duke@openjdk.java.net> wrote:

> The inconsistent illumination happens on Macs with retina displays only if the 3D \
> shape is placed in a SubScene. The light sources are located with wrong coordinates \
> in sub scenes and this causes a different illumination. The wrong coordinates for \
> the light sources come from the fact that the retina pixel scale factors are not \
> used in a SubScene. 
> With this pull request, the retina pixel scale factors will be also used in \
> SubScenes and this should resolve the bug \
> [https://bugs.openjdk.java.net/browse/JDK-8255015](url)

This pull request has now been integrated.

Changeset: 161e434b
Author:    andreas-heger <heger@gmx.de>
Committer: Nir Lisker <nlisker@openjdk.org>
URL:       https://git.openjdk.java.net/jfx/commit/161e434b1238d657f95e5ffcd3749027e066ca76
                
Stats:     184 lines in 2 files changed: 184 ins; 0 del; 0 mod

8255015: Inconsistent illumination of 3D shape by PointLight

Reviewed-by: kcr, arapte

-------------

PR: https://git.openjdk.java.net/jfx/pull/531


[prev in list] [next in list] [prev in thread] [next in thread]