[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8275848: Deprecate mistakenly exposed field from class javafx.scene.shape.Box
From:       Kevin Rushforth <kcr () openjdk ! java ! net>
Date:       2021-10-29 11:33:12
Message-ID: EydApuNF3AwU8XWyYkuZ9q34ETxg5LOVi0yYzo6Z3X0=.a2396000-aced-43c2-8a57-b1d227788a7f () github ! com
[Download RAW message or body]

On Fri, 29 Oct 2021 07:31:05 GMT, Ajit Ghaisas <aghaisas@openjdk.org> wrote:

> This PR deprecates mistakenly exposed field from class javafx.scene.shape.Box.

This looks good with one minor comment. Please also change the title of the JBS \
issues (both the bug and the CSR) and this PR to add "for removal" after "Deprecate". \
So maybe:


Deprecate for removal mistakenly exposed field from javafx.scene.shape.Box

modules/javafx.graphics/src/main/java/javafx/scene/shape/Box.java line 90:

> 88:     /**
> 89:      * Default size of the {@code Box}.
> 90:      * @deprecated This field was exposed mistakenly and will be removed

Can you add a period at the end?

-------------

PR: https://git.openjdk.java.net/jfx/pull/655


[prev in list] [next in list] [prev in thread] [next in thread]