[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8187474: Tree-/TableCell, TreeCell: editingCell/Item not updated in cell.startEdit [v3]
From:       Ajit Ghaisas <aghaisas () openjdk ! java ! net>
Date:       2021-10-29 10:19:16
Message-ID: IfdHV6AAdzVmcfztVBc5UeQHO8nZGDh65gOuJWmsRHI=.b5d87ea7-f563-4992-a646-a1773d2f91e6 () github ! com
[Download RAW message or body]

On Fri, 22 Oct 2021 10:36:24 GMT, Jeanette Winzenburg <fastegal@openjdk.org> wrote:

> > cell startEdit is supposed to update the editing location on its associated \
> > control - was done in ListCell, not in Tree-/TableCell nor TreeCell. 
> > Fix was to add control.edit(..). Note that ListCell was also touched to use the \
> > exact same method call pattern as the fixed cell types. 
> > Added/unignored cell tests that are failing/passing before/after the fix.
> 
> Jeanette Winzenburg has updated the pull request incrementally with one additional \
> commit since the last revision: 
> next try with fixing the formatting

Marked as reviewed by aghaisas (Reviewer).

-------------

PR: https://git.openjdk.java.net/jfx/pull/638


[prev in list] [next in list] [prev in thread] [next in thread]