[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8255015: Inconsistent illumination of 3D shape by PointLight [v13]
From:       Ambarish Rapte <arapte () openjdk ! java ! net>
Date:       2021-10-29 6:06:28
Message-ID: lbYtlG43r0-4ZoclhCYf_OJ0veW1aAD3FiXjIdBhaRE=.e3a64604-d4d3-4de5-8f37-1a4b65df5cf5 () github ! com
[Download RAW message or body]

On Thu, 28 Oct 2021 13:50:40 GMT, Andreas Heger <duke@openjdk.java.net> wrote:

> > The inconsistent illumination happens on Macs with retina displays only if the 3D \
> > shape is placed in a SubScene. The light sources are located with wrong \
> > coordinates in sub scenes and this causes a different illumination. The wrong \
> > coordinates for the light sources come from the fact that the retina pixel scale \
> > factors are not used in a SubScene. 
> > With this pull request, the retina pixel scale factors will be also used in \
> > SubScenes and this should resolve the bug \
> > [https://bugs.openjdk.java.net/browse/JDK-8255015](url)
> 
> Andreas Heger has updated the pull request incrementally with one additional commit \
> since the last revision: 
> 8255015: Copyright year and wrong spelling in comment corrected

Marked as reviewed by arapte (Reviewer).

-------------

PR: https://git.openjdk.java.net/jfx/pull/531


[prev in list] [next in list] [prev in thread] [next in thread]