[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8271091: Missing API docs in UI controls classes [v5]
From:       Nir Lisker <nlisker () openjdk ! java ! net>
Date:       2021-10-29 2:15:13
Message-ID: z7CyENVhXVUE9aO__AQ7MCy4k15iWm9oK562iNclzHI=.bf348e87-14d5-4c93-90dc-5af8a6f364e7 () github ! com
[Download RAW message or body]

On Thu, 28 Oct 2021 14:27:52 GMT, Ajit Ghaisas <aghaisas@openjdk.org> wrote:

> > This PR fixes javadoc warnings in javafx.controls and javafx.web modules.
> > Note : 
> > - The javadoc needs to be generated with the JDK 18 EA build.
> > - 2 javadoc warnings in javafx.controls TabPane class will be fixed under - \
> >                 [JDK-8271085](https://bugs.openjdk.java.net/browse/JDK-8271085)
> > - There are still 20 javadoc warnings remaining in javafx.controls module and 3 \
> > warnings remaining in javafx.web module. The root cause is different and they \
> > will be addressed under \
> > [JDK-8270996](https://bugs.openjdk.java.net/browse/JDK-8270996)
> 
> Ajit Ghaisas has updated the pull request incrementally with one additional commit \
> since the last revision: 
> fix review comments

I didn't check the generated HTML pages or the correctness of the docs with respect \
to the functionality of their methods, but the docs themselves look good.

-------------

Marked as reviewed by nlisker (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/646


[prev in list] [next in list] [prev in thread] [next in thread]