[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    RFR: 8274433: All Cells: misbehavior of startEdit
From:       Jeanette Winzenburg <fastegal () openjdk ! java ! net>
Date:       2021-09-30 12:06:06
Message-ID: CADfx0zqc2y5SNP1307JETO8WQkbj2GzOjsPt-GD9rQ=.40c645b5-7f78-49ed-ae16-388c6cd1a457 () github ! com
[Download RAW message or body]

The misbehavior happens if (super) startEdit didn't succeed (== !cell.isEditing):

- must not fire editStart event
- must not update control's editing location

fix is to back out of startEdit if super.startEdit doesn't switch the cell into \
editing mode

Added tests that failed/passed before/after the fix. Note that for Tree-, Table-, \
TreeTableCell one of the added tests would be a false green due to those cells not \
updating the editing location on its control \
[JDK-8187474](https://bugs.openjdk.java.net/browse/JDK-8187474), so it's ignore until \
that's fixed.

-------------

Commit messages:
 - 8274433: All Cells: misbehavior of startEdit

Changes: https://git.openjdk.java.net/jfx/pull/636/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jfx&pr=636&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8274433
  Stats: 107 lines in 8 files changed: 107 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jfx/pull/636.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/636/head:pull/636

PR: https://git.openjdk.java.net/jfx/pull/636


[prev in list] [next in list] [prev in thread] [next in thread]