[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8273485: Deadlock when also using Swing and exiting Fullscreen on Mac [v6]
From:       Florian Kirmaier <fkirmaier () openjdk ! java ! net>
Date:       2021-09-28 12:15:30
Message-ID: K9P--ldspqbv7Dv34RqKhPPLoXISLuGc7bS8N4nY1eI=.c28d5a82-f536-4142-b61e-0263dea97afb () github ! com
[Download RAW message or body]

On Tue, 28 Sep 2021 12:07:36 GMT, Florian Kirmaier <fkirmaier@openjdk.org> wrote:

> > When using Swing it's possible to generate a Deadlock.
> > It's related to the nested eventloop started in enterFullScreenExitingLoop - and \
> > the RenderLock aquired when using setView in Scene. Sample Programm and \
> > Threaddump are added to the ticket. 
> > Removing the nested loop fixes the Problem. 
> > I hope this doesn't have any side effect - so far i don't know of any.
> 
> Florian Kirmaier has updated the pull request incrementally with one additional \
> commit since the last revision: 
> JDK-8273485
> removed the toggle fullscreen before closing - to avoid the beep and improve the \
> user experience

I've just noticed that I've missed to commit a change, to prevent the beep - which \
I've now added.

The changes I've now committed also have another welcome side effects:
JavaFX behaves more like "normal" Mac apps.
 Before:
 - Animation out of fullscreen
 - Closing the window
 Now:
 - Closing the window
This is how other mac applications behave - and should probably therefore be \
preferred. I've tested it with apps like Finder, Textedit, Chrome, Safari.

-------------

PR: https://git.openjdk.java.net/jfx/pull/622


[prev in list] [next in list] [prev in thread] [next in thread]