[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8271474: Tree-/TableCell: inconsistent edit event firing pattern
From:       Ajit Ghaisas <aghaisas () openjdk ! java ! net>
Date:       2021-09-24 11:57:53
Message-ID: chIJ7y5LltQ-mThGhBktqQ_jub2H5Ll1JKG-YQ4Tmfg=.06f4f6d7-c10d-48cd-8b0b-a307408ad8f6 () github ! com
[Download RAW message or body]

On Tue, 7 Sep 2021 14:53:50 GMT, Jeanette Winzenburg <fastegal@openjdk.org> wrote:

> this PR fixes the inconsistent event firing pattern in cell's xxEdit methods \
> (please see the issue for more details): 
> - fires event if column != null
> - accesses table state if table != null
> 
> The first requires a change in CellEditEvent which now allows null table in its \
> constructor. 
> Added tests that failed/passed before/after the fix (along with some that also \
> passed before for complete coverage of state permutations). Changed two old test \
> methods which passed/failed before/after the fix - but did test the wrong thingy \
> anyway ;)

Marked as reviewed by aghaisas (Reviewer).

-------------

PR: https://git.openjdk.java.net/jfx/pull/620


[prev in list] [next in list] [prev in thread] [next in thread]