[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    RFR: 8218745: TableView: visual glitch at borders on horizontal scrolling
From:       Marius Hanl <mhanl () openjdk ! java ! net>
Date:       2021-09-23 19:11:13
Message-ID: TcI0ahDPMkfnL-9QBkLDnKCXhg_QA0ZAB1htDNWjCjQ=.bff3ab4e-238f-45a3-ad21-504e8412819f () github ! com
[Download RAW message or body]

This PR fixes an issue which is probably in JavaFX since VirtualFlow exists.
While horizontal scrolling any VirtualFlow control the left blue border sometimes \
disappear/gets smaller. (see also image below)

This can be fixed by **snapping** the scroll bar value (similar like e.g. a \
**ScrollPane** does).  The same needs to be done on the table header as otherwise the \
column lines might be 1 px off to the cell lines.  As a side effect this also fixes \
that the column lines sometimes get's blurry when horizontal scrolling (see second \
image).

While testing with **-Dglass.win.uiScale** I found out that the problem is not fixed \
for a scale like 1.25 or 1.5, while it is fixed for 1 or 2. The border sometimes \
disappears only when the snapped value is a decimal number (which obviously does not \
happen on a scale of 1 or 2), e.g. something like 12.6 but it will never disappear \
when it's a normal number, so e.g. just 12.

That's why something like **Math.round(..)** or just a **cast** to an **int** instead \
of snapping fixes this problem for all scales. I also didn't notice any side effect. \
But not sure if this the right fix then.  How does JavaFX render a **node** when e.g. \
the x is a decimal number? And does a decimal number make sense (Why we e.g. don't \
round the value)?

Another explanation could also be that there is an issue somewhere deep inside the \
node layout/snapping/Clip/Group/pixel rendering and to simply round/cast the value \
just fixes the symptom here.

In any case I'm open for any feedback, help or explanation.
I'm also glad for anything which might help identify the root cause here, if any.

---
1.
![image](https://user-images.githubusercontent.com/66004280/134562508-bea6ab9d-d3d0-4dbb-b0ce-dc6570a94ed7.png)
                
---
2.
![image](https://user-images.githubusercontent.com/66004280/134563377-970b4e48-8528-4dad-95fb-fb93780413e8.png)


-------------

Commit messages:
 - 8218745: Snapping X/Y when scrolling

Changes: https://git.openjdk.java.net/jfx/pull/630/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jfx&pr=630&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8218745
  Stats: 59 lines in 6 files changed: 55 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/jfx/pull/630.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/630/head:pull/630

PR: https://git.openjdk.java.net/jfx/pull/630


[prev in list] [next in list] [prev in thread] [next in thread]