[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8267059: Gradle :clean and :apps tasks fail on Windows if ANT_HOME contains spaces [v2]
From:       Kevin Rushforth <kcr () openjdk ! java ! net>
Date:       2021-08-27 13:42:26
Message-ID: u3-2UlyT1qfKWHH5644VZJj1oogc1M7bxanGgLbyTrg=.d919538f-f85f-447d-8cdf-d863caa3c264 () github ! com
[Download RAW message or body]

On Fri, 4 Jun 2021 05:04:17 GMT, Michael Strauß <mstrauss@openjdk.org> wrote:

> > This PR fixes an issue when building OpenJFX on Windows and command-line \
> > arguments contain paths with spaces. 
> > The problem is that on Windows, `ant` is invoked via `cmd`, which leads to quotes \
> > being interpreted twice. This can be fixed with the option `cmd /s`, which \
> > prevents interpreting quotes on the rest of the command line. The result is as if \
> > the rest of the command line had been typed verbatim at the command prompt.
> 
> Michael Strauß has updated the pull request with a new target base due to a merge \
> or a rebase. The incremental webrev excludes the unrelated changes brought in by \
> the merge/rebase. The pull request contains two additional commits since the last \
> revision: 
> - Merge branch 'master' into fixes/JDK-8267059
> - Use cmd /s option when building on Windows

@tiainen or @arapte can one of you be the second reviewer on this?

-------------

PR: https://git.openjdk.java.net/jfx/pull/499


[prev in list] [next in list] [prev in thread] [next in thread]