[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8253351: MediaPlayer does not display an mp4 if there no speakers connected to the PC's [v2
From:       Johan Vos <jvos () openjdk ! java ! net>
Date:       2021-07-28 18:31:44
Message-ID: 7GrI_LzQgxauPN1SIYngkDgK88SaFyqV7Lui4Rn9q5U=.dea31825-89f2-42f1-a8a1-8c89d3111274 () github ! com
[Download RAW message or body]

On Mon, 26 Jul 2021 22:23:20 GMT, Alexander Matveev <almatvee@openjdk.org> wrote:

> > Fixed by not failing initialization if DSERR_NODRIVER is returned, which will be \
> > return if device is not present at all. Fixed format initialization even if \
> > DirectSound device was not created in case if audio device will arrive after \
> > playback started. Since we already handle correctly device arrival after playback \
> > started, audio will resume if device is enabled or USB audio card is plugged \
> > back. Due to lack of access to USB audio device, it was tested by disabling sound \
> > card via Device Manager, then starting playback (video plays, but not audio) and \
> > then enabling device and once enabled audio will start playing.
> 
> Alexander Matveev has updated the pull request with a new target base due to a \
> merge or a rebase. The incremental webrev excludes the unrelated changes brought in \
> by the merge/rebase. The pull request contains two additional commits since the \
> last revision: 
> - Merge remote-tracking branch 'upstream/master' into JDK-8253351
> - 8253351: MediaPlayer does not display an mp4 if there no speakers connected to \
> the PC's

Looks good. In the old and new code, there are some memory operations that I'm a \
little worried about, but as far as I can tell there are no changes related to that \
between the old and the new code -- at least I don't see a scenario where a free \
occurs now while it didn't occur before.

-------------

Marked as reviewed by jvos (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/586


[prev in list] [next in list] [prev in thread] [next in thread]