[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: Eclipse: any way to checkout a PR for review?
From:       Nir Lisker <nlisker () gmail ! com>
Date:       2021-07-28 10:03:58
Message-ID: CA+0ynh_UM4nSrDX20eFU3-xioO8z_JNHAH6mwXiSnG+A06G2ug () mail ! gmail ! com
[Download RAW message or body]

A Pull Request is a GitHub feature, it doesn't exist in Git generally, so
EGit (I assume that's what you also use) is oblivious to PRs. Maybe there
is a special plugin for GitHubs or PRs.

Also, adding a remote is a one-time operation. Most contributors are
recurring, so for me reviewing amounts to a right click > pull on the
remote and a double click on the branch to check it out. I don't see any
inconvenience.

On Wed, Jul 28, 2021 at 12:45 PM Jeanette Winzenburg <
fastegal@swingempire.de> wrote:

>
> Zitat von Nir Lisker <nlisker@gmail.com>:
>
> > I'm not really sure what you mean. If you pull from the remote that the
> PR
> > is on and checkout the remote branch, is it not good enough for a review?
> >
>
> yeah, that's what I meant - without having been too clear - with
> fork-the-fork :) What I had hoped for was some hidden eclipse magic to
> directly access a PR as branch (from jfx) - something like the Pull
> requests tab in GitHub Desktop. Which under the hood adds a new remote
> to the fork that created the pr. And that's what I ended up with: add
> that remote manually and checkout the branch.
>
> Thanks for your input!
>
> -- Jeanette
>
>
>
> > On Tue, Jul 27, 2021 at 2:16 PM Jeanette Winzenburg <
> fastegal@swingempire.de>
> > wrote:
> >
> >>
> >> when reviewing a PR with only a few files changed, I simply create a
> >> local branch and c&p the changes (*cough, pretty sure there's a better
> >> way, but then that's the most simple ;).
> >>
> >> With changes to many files (like f.i.
> >> https://github.com/openjdk/jfx/pull/569) that still would be doable,
> >> but rather cumbersome - so looking for something like "gh pr checkout
> >> 569" (not that I ever tried that, just copied from the doc :) inside
> >> Eclipse.
> >>
> >> An alternative might be to fork-the-fork .. ?
> >>
> >> -- Jeanette
> >>
> >>
>
>
>
>
[prev in list] [next in list] [prev in thread] [next in thread]