[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    RFR: 8089398: [ChoiceBox, ComboBox] throws NPE on setting value on null selectionModel
From:       Marius Hanl <mhanl () openjdk ! java ! net>
Date:       2021-06-30 15:09:22
Message-ID: mdsT6rg2vJhXK5Yc3--HDTdmH_2evgmZSpW3FQpGzWc=.d9741a42-de06-45f8-9994-42a7a073f0c8 () github ! com
[Download RAW message or body]

This PR fixes 2 NPEs in Choice-and ComboBox, when the selection model is null.

ChoiceBox: 
- Null check in **valueProperty()** listener

ComboBox:
- Null check in **valueProperty()** listener
- Null check in **ComboBoxListViewSkin#updateValue()**

The tests checks, that no NPE is printed to the console (JUnit5 has the \
**assertDoesNotThrow​()** method, but 4 unfortunately has not). They also checks, \
that the set value is still displayed (either in the ComboBox button cell or the \
ChoiceBox display label)

-------------

Commit messages:
 - 8089398: [ChoiceBox, ComboBox] throws NPE on setting value on null selectionModel

Changes: https://git.openjdk.java.net/jfx/pull/557/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jfx&pr=557&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8089398
  Stats: 71 lines in 5 files changed: 62 ins; 3 del; 6 mod
  Patch: https://git.openjdk.java.net/jfx/pull/557.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/557/head:pull/557

PR: https://git.openjdk.java.net/jfx/pull/557


[prev in list] [next in list] [prev in thread] [next in thread]