[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Integrated: 8267418: IntelliJ build and test of JavaFX does not work
From:       Marius Hanl <mhanl () openjdk ! java ! net>
Date:       2021-06-30 4:19:05
Message-ID: apdSSxF-Fwjy1ZOBYIHk-UguvUeHXy33u4zpH_s1W54=.5c765ede-d09e-462b-8420-dd16d50a00e6 () github ! com
[Download RAW message or body]

On Wed, 19 May 2021 16:12:45 GMT, Marius Hanl <mhanl@openjdk.org> wrote:

> ~~Question: I was wondering, should I create a ticket for this as well? Given the \
> fact that I don't have an https://bugs.openjdk.java.net account, I need to use the \
> official bug reporting tool, which looked a bit overkill to me since someone needs \
> to check my created ticket, while this PR is only affecting the IntelliJ IDE with \
>                 OpenJFX and not the JavaFX platform directly.~~
> EDIT: Thank you, Kevin. :)
> 
> This PR fixes the errors you get when cloning and working with OpenJFX in IntelliJ \
>                 IDE:
> - The **.idea/misc.xml** is modified to use **JDK_11** as language level instead of \
>                 JDK_8. 
> -> This is the language level shown inside the **Project Structure**. (File -> \
>                 Project Structure...)
> - The **.idea/base.iml, .idea/controls.iml, .idea/fxml.iml, .idea/web.iml, \
> .idea/graphics.iml** are modified to include/recognize the shims (as test resource, \
>                 this is very similar to the configuration inside the .classpath \
>                 file from Eclipse)
> - EDIT: The projects are now recognized by IntelliJ-gradle (**.idea/gradle.xml**, \
> **.idea/compiler.xml**) 
> **-> With this, I can run all normal tests with IntelliJ**
> 
> ### What I couldn't fix yet (When I tried, it looked like IntelliJ is overriding \
>                 the settings on next gradle reload): 
> - IntelliJ is not detecting javafx.graphic inside the shims
> - All javafx.* dependencies are not found for the system tests
> 
> **-> If someone has a solution, feel free to comment :)**

This pull request has now been integrated.

Changeset: a1be1d59
Author:    Marius Hanl <mhanl@openjdk.org>
Committer: Ambarish Rapte <arapte@openjdk.org>
URL:       https://git.openjdk.java.net/jfx/commit/a1be1d591c0bf0bc118ffb8a4d1c4c8cc236b689
                
Stats:     50 lines in 8 files changed: 30 ins; 13 del; 7 mod

8267418: IntelliJ build and test of JavaFX does not work

Reviewed-by: arapte

-------------

PR: https://git.openjdk.java.net/jfx/pull/506


[prev in list] [next in list] [prev in thread] [next in thread]