[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8268642: Expand the javafx.beans.property.Property documentation [v2]
From:       Marius Hanl <mhanl () openjdk ! java ! net>
Date:       2021-06-28 14:04:07
Message-ID: QjGCWKcNCY3A59mCWi4dH7gw86dLfemzH8QSkQZzfts=.eb15588a-0f54-4b6f-822a-8a9e54fe249e () github ! com
[Download RAW message or body]

On Thu, 24 Jun 2021 01:53:53 GMT, Michael Strauß <mstrauss@openjdk.org> wrote:

> > * Expand the `Property.bind` and `Property.bindBidirectional` documentation
> > * Change the name of the formal parameter of `Property.bind` to "source" \
> > (currently, it is inconsistently named "observable", "rawObservable" or \
> > "newObservable")
> 
> Michael Strauß has updated the pull request incrementally with one additional \
> commit since the last revision: 
> changes as per review

I like this change, it makes the binding framework doc much more clear. But I agree \
with Nir, I think 'the' reads better then 'a' on the occurrences.

-------------

PR: https://git.openjdk.java.net/jfx/pull/533


[prev in list] [next in list] [prev in thread] [next in thread]