[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Integrated: 8137323: Incorrect parsing of mnemonic in controls text
From:       mstr2 <github.com+43553916+mstr2 () openjdk ! java ! net>
Date:       2021-04-30 14:53:55
Message-ID: dxS3RbCYJEePlklOmZRSskr7ColqODzOjwxxW9q7gXw=.0a5c1c2b-a443-4e69-a4b4-d5f1c4c50ceb () github ! com
[Download RAW message or body]

On Fri, 2 Apr 2021 19:47:30 GMT, mstr2 <github.com+43553916+mstr2@openjdk.org> wrote:

> This PR fixes incorrect parsing of mnemonic symbols in the following cases:
> 1. an escaped double underscore incorrectly shows up as a double underscore in \
> displayed text 2. an extended mnemonic incorrectly removes a part of adjacent text
> 
> As a side effect, this PR also fixes another undocumented issue for multiline text \
> where text metrics calculations incorrectly operate on text for which mnemonic \
> symbols have not been processed. 
> This can lead to a glitch where the mnemonic underscore makes a text just long \
> enough to wrap to a new line, but when the text is rendered, the second line shows \
> up entirely empty. The reason for this is that for rendering, the text is laid out \
> _after_ mnemonic symbols have been removed. 
> The solution is to _always_ use processed text ("_clean text_") when laying out \
> text.

This pull request has now been integrated.

Changeset: affb1084
Author:    mstr2 <43553916+mstr2@users.noreply.github.com>
Committer: Kevin Rushforth <kcr@openjdk.org>
URL:       https://git.openjdk.java.net/jfx/commit/affb10845bdf9a20f7e44c5b6a62883a892e4076
                
Stats:     251 lines in 3 files changed: 120 ins; 51 del; 80 mod

8137323: Incorrect parsing of mnemonic in controls text

Reviewed-by: aghaisas, kcr

-------------

PR: https://git.openjdk.java.net/jfx/pull/453


[prev in list] [next in list] [prev in thread] [next in thread]