[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8137323: Incorrect parsing of mnemonic in controls text
From:       Kevin Rushforth <kcr () openjdk ! java ! net>
Date:       2021-04-30 13:45:06
Message-ID: sMQ4VGLqHLaBIGCufa-MZOxTdSxHmh_V9A_om3K1HMI=.ed890776-4ba1-4114-b426-effe5b885ef0 () github ! com
[Download RAW message or body]

On Fri, 2 Apr 2021 19:47:30 GMT, mstr2 <github.com+43553916+mstr2@openjdk.org> wrote:

> This PR fixes incorrect parsing of mnemonic symbols in the following cases:
> 1. an escaped double underscore incorrectly shows up as a double underscore in \
> displayed text 2. an extended mnemonic incorrectly removes a part of adjacent text
> 
> As a side effect, this PR also fixes another undocumented issue for multiline text \
> where text metrics calculations incorrectly operate on text for which mnemonic \
> symbols have not been processed. 
> This can lead to a glitch where the mnemonic underscore makes a text just long \
> enough to wrap to a new line, but when the text is rendered, the second line shows \
> up entirely empty. The reason for this is that for rendering, the text is laid out \
> _after_ mnemonic symbols have been removed. 
> The solution is to _always_ use processed text ("_clean text_") when laying out \
> text.

Since extended mnemonics don't seem to work either before or after your fix -- \
meaning you can't use the extended mnemonic character to select the button or action \
-- we can treat that as a separate issue.

So this fix looks good to me.

-------------

Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.java.net/jfx/pull/453


[prev in list] [next in list] [prev in thread] [next in thread]