[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Integrated: 8265206: Tree-/TableCell: editing state not updated on cell re-use
From:       Jeanette Winzenburg <fastegal () openjdk ! java ! net>
Date:       2021-04-29 10:40:01
Message-ID: 5Xy2FmGwvY-3gCJx11nVPNoBmDT0hWPSGgaW3r6hoeU=.008a7c2e-f184-4153-b2db-7f6de630d86d () github ! com
[Download RAW message or body]

On Wed, 21 Apr 2021 11:29:38 GMT, Jeanette Winzenburg <fastegal@openjdk.org> wrote:

> Issue is missing update of Tree-/TableCell's editiable state when changing its \
> index from editingIndex to -1.  
> Seems to be a left-over from fixing cell's editing update - done in \
> [JDK-8150525](https://bugs.openjdk.java.net/browse/JDK-8150525) - on index change \
> for the special case of new index -1. 
> Fixed by cleaning out editing state in that corner case also, added tests that were \
> failing before and passing after the fix. Note that there are also tests that \
> passed before: the previous fix didn't add any tests, so added them here.

This pull request has now been integrated.

Changeset: ccf51e4f
Author:    Jeanette Winzenburg <fastegal@openjdk.org>
URL:       https://git.openjdk.java.net/jfx/commit/ccf51e4f4f005d28c3d8e577022b0dd91851910f
                
Stats:     566 lines in 6 files changed: 552 ins; 0 del; 14 mod

8265206: Tree-/TableCell: editing state not updated on cell re-use

Reviewed-by: aghaisas, jvos

-------------

PR: https://git.openjdk.java.net/jfx/pull/473


[prev in list] [next in list] [prev in thread] [next in thread]