[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8258777: SkinBase: add api to un-/register invalidation-/listChange listeners [v10]
From:       Ambarish Rapte <arapte () openjdk ! java ! net>
Date:       2021-04-28 11:15:01
Message-ID: 3vOETLtdujJTPfqnELiMqPmzRMxfXiIJVocLW7jwm0A=.d7af7857-8f29-45c5-b414-4ea35580e7eb () github ! com
[Download RAW message or body]

On Sat, 17 Apr 2021 13:48:23 GMT, Jeanette Winzenburg <fastegal@openjdk.org> wrote:

> > Changes in Lambda..Handler:
> > - added api and implemenation to support invalidation and listChange listeners in \
> >                 the same way as changeListeners
> > - added java doc 
> > - added tests
> > 
> > Changes in SkinBase
> > - added api (and implementation delegating to the handler)
> > - copied java doc from the change listener un/register methods 
> > - added tests to verify that the new (and old) api is indeed delegating to the \
> > handler 
> > Note that the null handling is slightly extended: all methods now can handle both \
> > null consumers (as before) and null observables (new) - this allows simplified \
> > code on rewiring "path" properties (see reference example in the issue)
> 
> Jeanette Winzenburg has updated the pull request incrementally with one additional \
> commit since the last revision: 
> changed according to review

Marked as reviewed by arapte (Reviewer).

-------------

PR: https://git.openjdk.java.net/jfx/pull/409


[prev in list] [next in list] [prev in thread] [next in thread]