[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8260528: Clean glass-gtk sizing and positioning code [v25]
From:       Pankaj Bansal <pbansal () openjdk ! java ! net>
Date:       2021-04-28 3:31:54
Message-ID: qu0yFv9fFu3hYIKyb1dbW1pJhPuB6WucRLcYvOIKs74=.50e97aea-d16b-4112-b149-8cfbfeca8a19 () github ! com
[Download RAW message or body]

On Wed, 10 Mar 2021 18:23:24 GMT, Thiago Milczarek Sayao <tsayao@openjdk.org> wrote:

> > This is a new approach to rewrite parts of gtk glass backend to be more clean.
> > 
> > I will provide small "manageable" PR to incrementally make the backend better.
> > 
> > This PR adresses cleanup of the Size and Positioning code. It makes code more \
> > "straightforward" and easier to maintain. 
> > Current status (Ubuntu 20.04):
> > ![image](https://user-images.githubusercontent.com/30704286/102702414-1b1b1800-4241-11eb-90bf-8ab737ce2e04.png)
> >  
> > (*) Some of the iconify tests are also failing on the main branch. 
> > 
> > `gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests \
> > test.robot.javafx.stage.IconifyTest` on a second run produces 4 tests, 2 \
> > failures.
> 
> Thiago Milczarek Sayao has updated the pull request incrementally with one \
> additional commit since the last revision: 
> Fix bug in content oriented child windows

I ran the full test on OL 8.2 and the results look fine.

-------------

PR: https://git.openjdk.java.net/jfx/pull/367


[prev in list] [next in list] [prev in thread] [next in thread]