[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8258663: Fixed size TableCells are not removed from sene graph when column is removed [v2]
From:       Marius Hanl <github.com+66004280+maran23 () openjdk ! java ! net>
Date:       2021-03-31 14:04:43
Message-ID: 6w736c2RBRr5nDs7fJCq8O_p3a2D_HfZ-BCI-nipIyw=.333d8868-ba74-4077-b387-6a12cffebf98 () github ! com
[Download RAW message or body]

On Wed, 31 Mar 2021 13:20:09 GMT, Kevin Rushforth <kcr@openjdk.org> wrote:

> > modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/TableRowSkinTest.java \
> > line 42: 
> > > 40: 
> > > 41: import static junit.framework.Assert.assertEquals;
> > > 42: 
> > 
> > shouldn't that be `org.junit.Assert.*` ?
> 
> I don't think @kleopatra was referring to whether or not to use a wild-card import, \
> but rather that the `Assert` class should be imported from the `org.junit` package \
> instead of `junit.framework`. We are inconsistent in our usage in some of the older \
> tests, but yes, we should use `org.junit`.

Oh, alright, didn't saw that. I will change it. :)

-------------

PR: https://git.openjdk.java.net/jfx/pull/444


[prev in list] [next in list] [prev in thread] [next in thread]