[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8255572: Axis does not compute preferred height properly when autoRanging is off [v6]
From:       Jeanette Winzenburg <fastegal () openjdk ! java ! net>
Date:       2021-03-30 10:19:39
Message-ID: ngVzgdMv7bBnjuqc7Wpvq5lP97aCeUQi8qrHTdxrsHU=.d7de4c36-8fce-4f7b-81c1-298c42e7e63f () github ! com
[Download RAW message or body]

On Mon, 29 Mar 2021 22:19:08 GMT, Jonathan Vusich \
<github.com+31666175+JonathanVusich@openjdk.org> wrote:

> 
> 
> @kleopatra @kevinrushforth Are the system tests that I have provided sufficient for \
> this PR to move forward or do they need to be rewritten as unit tests?

good question :) Personally, I would also add a unit test (even though it requires \
that hacky bit), it's more likely to be "seen". But also fine as-is, that is having \
system tests, IMO. Didn't run them, though .. *cough

-------------

PR: https://git.openjdk.java.net/jfx/pull/342


[prev in list] [next in list] [prev in thread] [next in thread]