[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8263402: MemoryLeak: Node hardreferences it's previous Parent after csslayout and getting r
From:       Florian Kirmaier <fkirmaier () openjdk ! java ! net>
Date:       2021-03-26 12:02:42
Message-ID: 1G9GVvRdI992pfjLkdDs-6fH3mlM-62sU2ld238BBsA=.72313c28-be98-4803-ac40-9940d2898e02 () github ! com
[Download RAW message or body]

On Tue, 23 Mar 2021 09:57:11 GMT, Ambarish Rapte <arapte@openjdk.org> wrote:

> > Florian Kirmaier has updated the pull request incrementally with one additional \
> > commit since the last revision: 
> > 8263402
> > Rewrote the style memoryleak test
> 
> Provided few comments on test.

I've added the requested changes from the codereview

> tests/system/src/test/java/test/javafx/scene/StyleMemoryLeakTest.java line 48:
> 
> > 46: import static org.junit.Assert.fail;
> > 47: import static org.junit.Assert.assertTrue;
> > 48: 
> 
> The packages Application, Node and Parent are not used.

done

> tests/system/src/test/java/test/javafx/scene/StyleMemoryLeakTest.java line 100:
> 
> > 98:         Platform.runLater(() -> {
> > 99:             Platform.exit();
> > 100:         });
> 
> `Platform.exit()` can be called from any thread. So `Platform.runLater` is not \
> required.

done

> tests/system/src/test/java/test/javafx/scene/StyleMemoryLeakTest.java line 102:
> 
> > 100:         });
> > 101:     }
> > 102: }
> 
> Include a new line at end of file.

done

-------------

PR: https://git.openjdk.java.net/jfx/pull/424


[prev in list] [next in list] [prev in thread] [next in thread]