[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8258777: SkinBase: add api to un-/register invalidation-/listChange listeners [v2]
From:       Jeanette Winzenburg <fastegal () openjdk ! java ! net>
Date:       2021-02-23 12:06:08
Message-ID: Q6SurwhUA4kECUaNVNyIFzRsvxlg--jmz-xcnQ59UZg=.be27fef2-279d-41a9-8f9f-7873484f9547 () github ! com
[Download RAW message or body]

> Changes in Lambda..Handler:
> - added api and implemenation to support invalidation and listChange listeners in \
>                 the same way as changeListeners
> - added java doc 
> - added tests
> 
> Changes in SkinBase
> - added api (and implementation delegating to the handler)
> - copied java doc from the change listener un/register methods 
> - added tests to verify that the new (and old) api is indeed delegating to the \
> handler 
> Note that the null handling is slightly extended: all methods now can handle both \
> null consumers (as before) and null observables (new) - this allows simplified code \
> on rewiring "path" properties (see reference example in the issue)

Jeanette Winzenburg has updated the pull request incrementally with one additional \
commit since the last revision:

  fixed missing/incorrect @since tags in new api doc

-------------

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/409/files
  - new: https://git.openjdk.java.net/jfx/pull/409/files/da0820a9..a342eba7

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=409&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=409&range=00-01

  Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jfx/pull/409.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/409/head:pull/409

PR: https://git.openjdk.java.net/jfx/pull/409


[prev in list] [next in list] [prev in thread] [next in thread]