[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-openjfx-dev
Subject: Re: RFR: 8260528: Clean glass-gtk sizing and positioning code [v13]
From: Thiago Milczarek Sayao <tsayao () openjdk ! java ! net>
Date: 2021-02-22 16:09:10
Message-ID: Wb38bli2eEsBCxPsrzBfy5qMdjbyMC3glBW7JQ9ON0o=.0d757056-0352-40e4-8a46-60d7ace66c4c () github ! com
[Download RAW message or body]
> This is a new approach to rewrite parts of gtk glass backend to be more clean.
>
> I will provide small "manageable" PR to incrementally make the backend better.
>
> This PR adresses cleanup of the Size and Positioning code. It makes code more \
> "straightforward" and easier to maintain.
> Current status (Ubuntu 20.04):
> ![image](https://user-images.githubusercontent.com/30704286/102702414-1b1b1800-4241-11eb-90bf-8ab737ce2e04.png)
>
> (*) Some of the iconify tests are also failing on the main branch.
>
> `gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests \
> test.robot.javafx.stage.IconifyTest` on a second run produces 4 tests, 2 failures.
Thiago Milczarek Sayao has updated the pull request incrementally with one additional \
commit since the last revision:
Default to 320x200 if no size is assigned
-------------
Changes:
- all: https://git.openjdk.java.net/jfx/pull/367/files
- new: https://git.openjdk.java.net/jfx/pull/367/files/6766502e..0c89a4da
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jfx&pr=367&range=12
- incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=367&range=11-12
Stats: 11 lines in 2 files changed: 10 ins; 0 del; 1 mod
Patch: https://git.openjdk.java.net/jfx/pull/367.diff
Fetch: git fetch https://git.openjdk.java.net/jfx pull/367/head:pull/367
PR: https://git.openjdk.java.net/jfx/pull/367
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic