[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8261927: WebKit build fails with Visual Studio 2017
From:       Guru Hb <ghb () openjdk ! java ! net>
Date:       2021-02-21 9:26:41
Message-ID: B2c7J5pPvOZSn3Y233Y65rSFerAZ3jeIZpP2B1ilNvc=.ed94f2b9-3501-44c8-9b4d-6a269ed83c54 () github ! com
[Download RAW message or body]

On Thu, 18 Feb 2021 13:25:14 GMT, Arun Joseph <ajoseph@openjdk.org> wrote:

> The WebKit build fails with Visual Studio 2017.
> 
> Issue: Visual Studio 2017 doesn't support if constexpr in lambda
> 
> Test: Build webkit with the VS2017 compiler with and without this fix. It should \
> fail without the fix and build with the fix.

Compiled and verified on VS 2017. Changes looks good to me.

-------------

Marked as reviewed by ghb (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/405


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic