[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8228363: ContextMenu.show with side=TOP does not work the first time in the presence of CSS
From:       Ajit Ghaisas <aghaisas () openjdk ! java ! net>
Date:       2021-01-27 13:12:49
Message-ID: FxAyYODs1eR-jQDL4x86Ju9Q3AT_i-G0E_X-Gvx3GuA=.576f9a46-df1a-4601-808d-e1af7b02c0a7 () github ! com
[Download RAW message or body]

On Wed, 27 Jan 2021 12:14:54 GMT, Robert Lichtenberger <rlichten@openjdk.org> wrote:

> > By using the anchor location facility of PopupWindows we can avoid miscalculation \
> > of the menu's height entirely.
> > This fix also cleans up some documentation issues.
> > This fix introduces tests that check the correct positioning (test_position_)
> > test_position_withCSS reproduces the problem that is fixed with this patch.
> > The other test_position_ cases serve as "proof" that no regressions are \
> > introduces. They work before and after the fix is introduced.
> 
> Robert Lichtenberger has updated the pull request incrementally with one additional \
> commit since the last revision: 
> 8228363: ContextMenu.show with side=TOP does not work the first time in the \
> presence of CSS 
> Removed unnecessary imports.

Marked as reviewed by aghaisas (Reviewer).

-------------

PR: https://git.openjdk.java.net/jfx/pull/383


[prev in list] [next in list] [prev in thread] [next in thread]