[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8234920: Add SpotLight to the selection of 3D light types [v7]
From:       Nir Lisker <nlisker () openjdk ! java ! net>
Date:       2020-12-31 10:16:57
Message-ID: CfLm7QUSUMu4sQruKVWln9_RsQNVMaNwkjwD_0V5TbI=.dad02399-4267-4202-9706-a874e650ba7e () github ! com
[Download RAW message or body]

On Tue, 24 Nov 2020 22:00:07 GMT, Kevin Rushforth <kcr@openjdk.org> wrote:

> > Nir Lisker has updated the pull request incrementally with one additional commit \
> > since the last revision: 
> > Update to the gl pipeline
> 
> I think the API looks good with a few comments about valid ranges.

The default direction was updated to (0, 0, 1) to points away from the camera instead \
of (0, 0, -1). I think it makes more sense. I also updated the default outer angle to \
30 instead of 90. I think that it is a more reasonable value for the use of a \
spotlight.

-------------

PR: https://git.openjdk.java.net/jfx/pull/334


[prev in list] [next in list] [prev in thread] [next in thread]