[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8255572: Axis does not compute preferred height properly when autoRanging is off [v4]
From:       Kevin Rushforth <kcr () openjdk ! java ! net>
Date:       2020-12-24 0:35:56
Message-ID: -fH6EW-r_Mv_9-yhjg7Ukv1y7BTl6i1lsNegE6d-nfQ=.dce56c08-f6ad-4f78-9c19-ac93028f1516 () github ! com
[Download RAW message or body]

On Wed, 25 Nov 2020 15:56:05 GMT, Jonathan Vusich \
<github.com+31666175+JonathanVusich@openjdk.org> wrote:

> > While this does fix the specific problem, it introduces a new one. If the labels \
> > are initially too big, but after resizing the window would now fit, it does not \
> > recompute the orientation. This means that you are left with labels that are \
> > rotated even when they don't need to be.
> 
> @kevinrushforth Thank you for catching that. Do you think it would be acceptable to \
> simply rotate the labels back to zero if the user expands the window?

The fix seems fine to me. I recommend also adding a test for a vertical axis.

-------------

PR: https://git.openjdk.java.net/jfx/pull/342


[prev in list] [next in list] [prev in thread] [next in thread]