[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8256983: GitHub actions: specify the version of each platform OS and compiler
From:       Ambarish Rapte <arapte () openjdk ! java ! net>
Date:       2020-12-14 6:07:54
Message-ID: i0iRmYD-QmV0r4U2SczMCP92TFVmnIYWIb5Nju0MZ78=.bae1f8a0-bc8f-4a3d-95e5-a868c907ebd3 () github ! com
[Download RAW message or body]

On Tue, 8 Dec 2020 20:06:21 GMT, Kevin Rushforth <kcr@openjdk.org> wrote:

> As described in the [JBS issue](https://bugs.openjdk.java.net/browse/JDK-8256983), \
> we should specify the specific version of each OS and compiler rather than just \
> using the defaults. This will help insulate us from changes to the defaults that \
> can break the build, and has recently done so. 
> On Linux, we upgraded to 20.04 (18.04 is still the default), which required \
> specifying the version of ant, since the default version for 20.04 is 1.10.7 which \
> has a bug that causes FX apps to fail. I decided to also specify the version of ant \
> (1.10.5) for all three platforms. 
> The following will be used:
> 
> > Platform | OS | Compiler | Ant |
> > --- | --- | --- | --- |
> > Linux | Ubuntu 20.04 | gcc 10.2 | ant 1.10.5 |
> > Mac | macOS 10.15 | Xcode 11.3.1 | ant 1.10.5 |
> > Windows | Windows Server 2019 | [1] | ant 1.10.5 |
> 
> [1] The Microsoft compiler version is unspecified as there is a dependency on \
> [JDK-8255713](https://bugs.openjdk.java.net/browse/JDK-8255713) in addition to the \
> problem of increasing the build time to download a specific version.

looks good to me.

-------------

Marked as reviewed by arapte (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/366


[prev in list] [next in list] [prev in thread] [next in thread]