[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8255572: Axis does not compute preferred height properly when autoRanging is off [v3]
From:       Jonathan Vusich <github.com+31666175+jonathanvusich () openjdk ! java ! net>
Date:       2020-11-25 18:06:10
Message-ID: 8LlhfU0Zb-0FAM7E1sOl-9LSEzP-unqsmkA8EhB9MiE=.e8024574-6050-4d0a-87a1-09f081136124 () github ! com
[Download RAW message or body]

> As noted in the corresponding JBS issue, `Axis` does not properly compute its \
> preferred height when `autoRanging` is turned off. The simplest fix seems to be \
> changing `CategoryAxis` so that `tickLabelRotation` is set to 90 degrees if there \
> is not enough room for the category labels to layout horizontally. This fixes the \
> fact that the axis labels are truncated and also ensures that the chart does not \
> leave unused space from the layout calculations. `CategoryAxis` is already setting \
> the `categorySpacing` property when `autoRanging` is off, so this seems to be an \
> appropriate fix.

Jonathan Vusich has updated the pull request incrementally with one additional commit \
since the last revision:

  Unrotate labels if there is enough space for them

-------------

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/342/files
  - new: https://git.openjdk.java.net/jfx/pull/342/files/49a5e1f7..6d83f79c

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=342&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=342&range=01-02

  Stats: 19 lines in 2 files changed: 14 ins; 2 del; 3 mod
  Patch: https://git.openjdk.java.net/jfx/pull/342.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/342/head:pull/342

PR: https://git.openjdk.java.net/jfx/pull/342


[prev in list] [next in list] [prev in thread] [next in thread]