[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8199592: Control labels truncated at certain DPI scaling levels [v2]
From:       Ambarish Rapte <arapte () openjdk ! java ! net>
Date:       2020-11-24 10:21:56
Message-ID: jCv1NLFpVofH9AipewwUKu2_1_ERTNje7IGdi_ncf6s=.758a464d-c907-46e0-883b-bc39633434ea () github ! com
[Download RAW message or body]

On Fri, 20 Nov 2020 11:30:18 GMT, Jose Pereda <jpereda@openjdk.org> wrote:

> > As commented in the [JBS \
> > issue](https://bugs.openjdk.java.net/browse/JDK-8199592), the default UI scale \
> > 1.0 is used to perform initial calculations of preferred sizes of the scene, even \
> > if the scale has already a different value (i.e 175%). As a workaround, calling \
> > `Stage::sizeToScene` fix it, as it forces to do new calculations but now with the \
> > correct UI scale. 
> > This PR moves the call to `Window::updateOutputScales` before the scene \
> > initialization takes place, so the UI scale is correctly set for the initial \
> > preferred size of the scene, and no workaround is required. 
> > It also provides a system test that can be tested on Linux and Windows. Before \
> > applying the fix, the `Check` text of the checkboxes is rendered as `Che...`. \
> > With the fix, the test verifies, for a given UI scale, that the rendered text is \
> > `Check`.
> 
> Jose Pereda has updated the pull request incrementally with one additional commit \
> since the last revision: 
> Use assertTrue instead of try-catch

Looks good to me, verified test and sample app on multi screen.

-------------

Marked as reviewed by arapte (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/351


[prev in list] [next in list] [prev in thread] [next in thread]