[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8256649: Parameterized tests must not use instances as parameters
From:       Jeanette Winzenburg <fastegal () openjdk ! java ! net>
Date:       2020-11-20 10:37:00
Message-ID: zA9x9KkaC0oUAbmLhWEhZ6JH5tA3QJW4nvAUcXfxpTo=.91b8c9c0-5676-4a53-81e7-00c68cde3a9c () github ! com
[Download RAW message or body]

On Thu, 19 Nov 2020 23:38:33 GMT, Kevin Rushforth <kcr@openjdk.org> wrote:

> 
> 
> Parameters should be immutable

would have been a far better bug title :)

> to avoid this. Each test runs in its own instance, but if a test stores a reference \
> to a parameter and then modifies it, that modification will leak into subsequent \
> tests. FWIW, the same thing can happen if a test modifies a static field or if it \
> modifies global state of the JavaFX runtime.

.. and nice summary as well

-------------

PR: https://git.openjdk.java.net/jfx/pull/356


[prev in list] [next in list] [prev in thread] [next in thread]