[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Integrated: 8255337: [TestBug] Controls unit tests - ButtonTest and ComboBoxTest - log ClassCastExce
From:       Ajit Ghaisas <aghaisas () openjdk ! java ! net>
Date:       2020-10-28 2:25:16
Message-ID: C5ndvtukwYIieh2EmOD5c_CKksIHxDJd3pUBrj0uXpA=.a6083273-b056-4fee-9bf5-2e88e2f7720c () github ! com
[Download RAW message or body]

On Fri, 23 Oct 2020 11:35:50 GMT, Ajit Ghaisas <aghaisas@openjdk.org> wrote:

> This is a test fix.
> 
> Root cause:
> - For ButtonTest - Incorrect use of MouseEventFirer - which puts Button on to the \
>                 stage and shows it before firing mouse event
> - For ComboBoxTest - adding ComboBox to a Stage, not showing the Stage but trying \
> to show the ComboBox 
> 
> Fix :
> - For ButtonTest - Moved MouseEventFirer usage from test class to the 2 tests that \
>                 need it
> - For ComboBoxTest - Started using StageLoader (which adds comboBox to the stage \
> and shows it) instead of separate Scene and Stage creation. 
> 
> I have attached the logs captured before and after this fix to the JBS.

This pull request has now been integrated.

Changeset: 690d2666
Author:    Ajit Ghaisas <aghaisas@openjdk.org>
URL:       https://git.openjdk.java.net/jfx/commit/690d2666
Stats:     156 lines in 2 files changed: 12 ins; 93 del; 51 mod

8255337: [TestBug] Controls unit tests - ButtonTest and ComboBoxTest - log \
ClassCastException

Reviewed-by: fastegal, kcr

-------------

PR: https://git.openjdk.java.net/jfx/pull/337


[prev in list] [next in list] [prev in thread] [next in thread]