[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8255337: [TestBug] Controls unit tests - ButtonTest and ComboBoxTest - log ClassCastExcepti
From:       Kevin Rushforth <kcr () openjdk ! java ! net>
Date:       2020-10-27 22:00:17
Message-ID: 3gNZr-QIdmLZlbxd7w9uMK-JfUK1txMPvg-1SuLlpq8=.330ce0f8-932c-4a38-bb47-e8b2be862e11 () github ! com
[Download RAW message or body]

On Tue, 27 Oct 2020 11:35:28 GMT, Ajit Ghaisas <aghaisas@openjdk.org> wrote:

> > This is a test fix.
> > 
> > Root cause:
> > - For ButtonTest - Incorrect use of MouseEventFirer - which puts Button on to the \
> >                 stage and shows it before firing mouse event
> > - For ComboBoxTest - adding ComboBox to a Stage, not showing the Stage but trying \
> > to show the ComboBox 
> > 
> > Fix :
> > - For ButtonTest - Moved MouseEventFirer usage from test class to the 2 tests \
> >                 that need it
> > - For ComboBoxTest - Started using StageLoader (which adds comboBox to the stage \
> > and shows it) instead of separate Scene and Stage creation. 
> > 
> > I have attached the logs captured before and after this fix to the JBS.
> 
> Ajit Ghaisas has updated the pull request incrementally with one additional commit \
> since the last revision: 
> review_fixes

Looks good.

-------------

Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.java.net/jfx/pull/337


[prev in list] [next in list] [prev in thread] [next in thread]