[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8251555: Remove unused focusedWindow field in glass Window to avoid leak
From:       Ambarish Rapte <arapte () openjdk ! java ! net>
Date:       2020-08-25 10:57:24
Message-ID: gX7gANwP2oFD1kMUR2TUDq4v2OGWfsZ-FuoVaXWUfxY=.4f7c40de-fe37-40a6-9cdd-f88abd9bf853 () github ! com
[Download RAW message or body]

On Sat, 22 Aug 2020 19:39:33 GMT, Kevin Rushforth <kcr@openjdk.org> wrote:

> This is a follow-up to \
> [JDK-8241840](https://bugs.openjdk.java.net/browse/JDK-8241840) that removes an \
> unused static `focusedWindow` field and its associated getter and setter from the \
> platform-independent glass Window class. This is entirely unused by any of the \
> glass platforms. The Monocle platform keeps track of the `focusedWindow` attribute \
> itself.  The existing `test.javafx.stage.FocusedWindowNativeTest` automated test, \
> which was added as part of \
> [JDK-8241840](https://bugs.openjdk.java.net/browse/JDK-8241840), was failing fairly \
> consistently on one of our test machines before this fix, and now passes.

Looks good to me.

-------------

Marked as reviewed by arapte (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/286


[prev in list] [next in list] [prev in thread] [next in thread]