[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8218973: SVG with masking is not rendering image with mask effect [v6]
From:       Bhawesh Choudhary <bchoudhary () openjdk ! java ! net>
Date:       2020-07-28 17:52:56
Message-ID: wXP2ZVxObRX-J5lgJaSRf48qHn7ieovLaQvWmbEFDEM=.df1bd39c-2694-4273-bba4-b8f0ed1d88aa () github ! com
[Download RAW message or body]

On Fri, 24 Jul 2020 12:10:00 GMT, Arun Joseph <ajoseph@openjdk.org> wrote:

> > Bhawesh Choudhary has updated the pull request incrementally with one additional \
> > commit since the last revision: 
> > HiDPI printing and Rendering fix
> 
> modules/javafx.web/src/main/native/Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp \
> line 93: 
> > 92:     auto deviceScaleFactor = document().deviceScaleFactor();
> > 93:     maskImageContext.applyDeviceScaleFactor(deviceScaleFactor);
> > 94:
> 
> For javafx port specific code in WebKit, it should be enclosed in `#if \
> PLATFORM(JAVA)`. But I think that there should be a better approach as other ports \
> don't require this scaling of `deviceScaleFactor`

RenderSVGResourceMasker.cpp changes are removed now.

-------------

PR: https://git.openjdk.java.net/jfx/pull/213


[prev in list] [next in list] [prev in thread] [next in thread]