[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8246745: ListCell/Skin: misbehavior on switching skin
From:       Jeanette Winzenburg <fastegal () openjdk ! java ! net>
Date:       2020-06-26 10:46:19
Message-ID: v-f8OO_ubbRfSA3m4-Dy4OpMvEKq0wYb6gQ4PF8kFzg=.ab862e4c-ba82-4368-b71e-5e576884a58a () github ! com
[Download RAW message or body]

On Wed, 10 Jun 2020 23:33:46 GMT, Kevin Rushforth <kcr@openjdk.org> wrote:

> > ListCellSkin installs listeners to the ListView/fixedCellSize that introduce a \
> > memory leak, NPE on replacing the listView and incorrect update of internal state \
> > (see bug report for details) Fixed by removing the listeners (and the internal \
> > state had been copied from listView on change) and access of listView state when \
> > needed. Added tests that failed before and pass after the fix, plus a sanity test \
> > to guarantee same (correct) behavior before/after.
> 
> @arapte can you review?

Hmm .. bottleneck seems to be layout as such (including css), accessing an instance \
field vs. querying a property doesn't make a difference (at least none I could see).

-------------

PR: https://git.openjdk.java.net/jfx/pull/251


[prev in list] [next in list] [prev in thread] [next in thread]