[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8245053: Keyboard doesn't show when TextInputControl has focus [v6]
From:       Abhinay Agarwal <github.com+3197675+abhinayagarwal () openjdk ! java ! net>
Date:       2020-06-25 18:20:55
Message-ID: VrxhmafHxR99nH5tTPQoIBa4ZZo5F0RENwqIN9k9eF8=.c1e41109-a6ad-4a0f-8fcf-836c075a0451 () github ! com
[Download RAW message or body]

> In Android, TextInputControls (TextField and TextArea) are responsible for showing \
> and hiding software keyboard. Currently, a focus listener is attached to these \
> controls and is used to toggle the visibility of keyboard. This condition fails in \
> cases where the control already has focus but the keyboard is not visible.  \
> Ideally, the keyboard should be shown again when the user taps on the \
> TextInputControl. This PR adds an event handler for `MouseEvent.MOUSE_CLICKED` \
> event and shows the keyboard  if the TextInput control is both editable and \
> focused.

Abhinay Agarwal has refreshed the contents of this pull request, and previous commits \
have been removed. The incremental views will show differences compared to the \
previous content of the PR. The pull request contains one new commit since the last \
revision:

  Show keyboard on mouse event. Focus change listener should be responsible for \
hiding the keyboard only.

-------------

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/219/files
  - new: https://git.openjdk.java.net/jfx/pull/219/files/0aa79029..b13c44b3

Webrevs:
 - full: https://webrevs.openjdk.java.net/jfx/219/webrev.05
 - incr: https://webrevs.openjdk.java.net/jfx/219/webrev.04-05

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jfx/pull/219.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/219/head:pull/219

PR: https://git.openjdk.java.net/jfx/pull/219


[prev in list] [next in list] [prev in thread] [next in thread]