[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Integrated: 8214699: Node.getPseudoClassStates must return the same instance on every call
From:       Ambarish Rapte <arapte () openjdk ! java ! net>
Date:       2020-06-23 13:27:41
Message-ID: Qd63ECZml5K8mm6XSLhqD7W3ZVYdu6jpLAQMEGPZjQw=.b325838e-d514-4420-b9a9-937d220776a4 () github ! com
[Download RAW message or body]

On Thu, 18 Jun 2020 16:30:42 GMT, Ambarish Rapte <arapte@openjdk.org> wrote:

> Node.getPseudoClassStates() returns a new UnmodifiableObservableSet of \
> PseudoClassState on each call. So in order to listen to any changes in this set, \
> user must call the method Node.getPseudoClassStates() only once and keep a strong \
> reference to the returned UnmodifiableObservableSet. 
> So the fix is that the method Node.getPseudoClassStates() should return the same \
> UnmodifiableObservableSet on every call. As the returned set is an \
> UnmodifiableObservableSet, it will not have any impact on it's usage. 
> Added a small unit test. and,
> Altered(minor) a test which was modified in
> past(https://github.com/openjdk/jfx/commit/0ac98695a1b11443c342fad4f009d6e03a052522)
>  (https://github.com/openjdk/jfx/commit/62323e0a9c5817b33daa262d6914eba0e8d274ff) \
> along with this method and should be updated in view of this change.

This pull request has now been integrated.

Changeset: a5878e05
Author:    Ambarish Rapte <arapte@openjdk.org>
URL:       https://git.openjdk.java.net/jfx/commit/a5878e05
Stats:     94 lines in 5 files changed: 7 ins; 84 del; 3 mod

8214699: Node.getPseudoClassStates must return the same instance on every call

Reviewed-by: fastegal, kcr

-------------

PR: https://git.openjdk.java.net/jfx/pull/253


[prev in list] [next in list] [prev in thread] [next in thread]