[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: [Rev 01] RFR: 8244195: [TEST_BUG] Convert the system tests TabPanePermuteGetTabsTest to unit tes
From:       Kevin Rushforth <kcr () openjdk ! java ! net>
Date:       2020-05-29 18:27:20
Message-ID: lqCXdp4Fa7LN0_0Q66Lw9iEhayJpeA5DCzI0g4ttUc0=.77226c49-3d09-4844-969b-b0b9c41807c5 () github ! com
[Download RAW message or body]

On Fri, 22 May 2020 12:15:04 GMT, Ambarish Rapte <arapte@openjdk.org> wrote:

> > As discussed [here](https://github.com/openjdk/jfx/pull/201#issuecomment-621772586) \
> > during #201 , This PR converts the system tests in TabPanePermuteGetTabsTest.java \
> > to unit test. Thanks @kleopatra , for providing the test. I have added few more \
> > tests and found few failures. \
> > [JDK-8245528](https://bugs.openjdk.java.net/browse/JDK-8245528) is created to fix \
> > these failures, the failing tests are currently ignored using this bug.
> > Please take a look.
> 
> Ambarish Rapte has updated the pull request incrementally with one additional \
> commit since the last revision: 
> fix review comments

Looks good.

-------------

Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.java.net/jfx/pull/230


[prev in list] [next in list] [prev in thread] [next in thread]