[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: [Rev 03] RFR: 8245053: Keyboard doesn't show when TextInputControl has focus
From:       Johan Vos <jvos () openjdk ! java ! net>
Date:       2020-05-29 16:50:36
Message-ID: MQKGurCSo7xmjF6Qszxb6ZbT4z1WvfMIB1eS_q94hEc=.e44431cd-09b4-4090-a52f-ea66dcae372b () github ! com
[Download RAW message or body]

On Fri, 29 May 2020 15:09:30 GMT, Abhinay Agarwal \
<github.com+3197675+abhinayagarwal@openjdk.org> wrote:

> > In Android, TextInputControls (TextField and TextArea) are responsible for \
> > showing and hiding software keyboard. Currently, a focus listener is attached to \
> > these controls and is used to toggle the visibility of keyboard. This condition \
> > fails in cases where the control already has focus but the keyboard is not \
> > visible.  Ideally, the keyboard should be shown again when the user taps on the \
> > TextInputControl. This PR adds an event handler for `MouseEvent.MOUSE_CLICKED` \
> > event and shows the keyboard  if the TextInput control is both editable and \
> > focused.
> 
> Abhinay Agarwal has updated the pull request incrementally with one additional \
> commit since the last revision: 
> Fix typo: dispose should remove event handler

worth discussing the case were a TextInput is the only control.

-------------

PR: https://git.openjdk.java.net/jfx/pull/219


[prev in list] [next in list] [prev in thread] [next in thread]