[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8244657: ChoiceBox/ToolBarSkin: misbehavior on switching skin
From:       Ajit Ghaisas <aghaisas () openjdk ! java ! net>
Date:       2020-05-29 5:37:21
Message-ID: EL43uiq-QNT936EYVJRpj7o18_b7IxZih8u3iMG9sz8=.131b9383-2af3-44a0-97d4-47ab4327a9f2 () github ! com
[Download RAW message or body]

On Tue, 26 May 2020 13:41:15 GMT, Jeanette Winzenburg <fastegal@openjdk.org> wrote:

> Both skins have similar misbehavior when switching skins
> 
> - memory leak due to a manually added but not removed change listener
> - NPE when modifying items after skin switch due to a not removed listener to the \
> control's items 
> Fixed in both (for details see the issue). Added SkinCleanupTest for simple testing \
> of per-control side-effects, removed both skins from memory test exclusion list: \
> failing before and passing after fix.

Marked as reviewed by aghaisas (Reviewer).

-------------

PR: https://git.openjdk.java.net/jfx/pull/238


[prev in list] [next in list] [prev in thread] [next in thread]