[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: [Rev 01] RFR: 8245499: Text input controls should show handles on iOS
From:       Johan Vos <jvos () openjdk ! java ! net>
Date:       2020-05-27 7:47:14
Message-ID: ozy65kzBOlcePPdV6IyeAlFRzGPiTY3JVEXwB5CZrkE=.a7d528df-7a60-4d3b-9eda-60153116c9c2 () github ! com
[Download RAW message or body]

On Tue, 26 May 2020 17:33:20 GMT, Jose Pereda <jpereda@openjdk.org> wrote:

> > After JDK-8242167, a JavaFX control is used for text input on iOS instead of the \
> > native control, on a touch enabled device. However, selection handles are not \
> > enabled and currently text selection is not possible at all. This PR enables \
> > handles on iOS as in the rest of the platforms with touch support. 
> > It also tries to accommodate its style to the native style for handles, where \
> > selection handles have a circle shape and are a little bit bigger, and there is \
> > no caret handle. I've tested it on iPhone, running a small
> > [HelloFX](https://github.com/gluonhq/client-samples/tree/master/Maven/HelloFX) \
> > sample, with a TextField control.
> 
> Jose Pereda has updated the pull request incrementally with one additional commit \
> since the last revision: 
> Add new line at the end of the file

Marked as reviewed by jvos (Reviewer).

-------------

PR: https://git.openjdk.java.net/jfx/pull/231


[prev in list] [next in list] [prev in thread] [next in thread]