[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: Gradle support for getting :web:test working properly
From:       Kevin Rushforth <kevin.rushforth () oracle ! com>
Date:       2020-04-30 19:49:22
Message-ID: b60017f9-08f9-5625-9cdc-ecd7ab1427b6 () oracle ! com
[Download RAW message or body]

I went ahead and created the JBS bug that you will need for this:

https://bugs.openjdk.java.net/browse/JDK-8244212

-- Kevin


On 4/30/2020 11:59 AM, Jesper Skov wrote:
> I have created https://github.com/openjdk/jfx/pull/202 with a suggested
> implementation.
>
> Looking for feedback.
>
> Cheers,
> Jesper
>
> On Fri, Apr 24, 2020 at 5:13 PM Jesper Skov <jskov@zoftcorp.dk> wrote:
>
>> Thanks, I will give it a shot.
>>
>> Jesper
>>
>>
>> On Thu, Apr 23, 2020 at 7:45 PM Kevin Rushforth <
>> kevin.rushforth@oracle.com> wrote:
>>
>>> That's an interesting idea that might be worth pursuing. It would help
>>> mitigate what has been a long-standing pain point for developers who
>>> don't want to build media or web, but would like to run them. I would
>>> caution, though, that it is still not a substitute for building both
>>> media and WebKit yourself, since it will still not work reliably in the
>>> case where there is an interface change or some other mutually dependent
>>> change between the native media or web library and Java class files. In
>>> those cases you are stuck until a new EA build is available.
>>>
>>> If you do want to pursue this, then as long as the dependency on
>>> org.openjfx:javafx-web and org.openjfx:javafx-media is localized to the
>>> downloading and unpacking step you mentioned, this would be fine with
>>> me. Maybe others could help test it on Mac and Windows.
>>>
>>> As for the name of the new property, maybe STUB_RUNTIME_OPENJFX? The
>>> easiest way to implement this might be to set the value of
>>> `defaultStubRuntime` to the directory into which you unpack it
>>> (underneath either build or buildSrc/build).
>>>
>>> -- Kevin
>>>
>>>
>>> On 4/23/2020 1:14 AM, Jesper Skov wrote:
>>>> Hi
>>>>
>>>> I struggled somewhat to get :web:test running with -PSTUB_RUNTIME.
>>>>
>>>> The JVM kept crashing by what turned out to be missing media
>>>> libraries (the failure message was hidden).
>>>>
>>>> I tried building with -PCOMPILE_WEBKIT=true, but it takes a terrible
>>>> long time on my laptop. And did not in itself fix the problem.
>>>>
>>>> Frustrations and lost time was the only real outcome of this :)
>>>>
>>>>
>>>>
>>>>
>>>> So I would suggest adding logic to the build file to allow something
>>>> like:
>>>>
>>>>       gradlew -PSTUB_RUNTIME_USE=15-ea+4 all test
>>>>
>>>> This should download org.openjfx:javafx-web and
>>>> org.openjfx:javafx-media artifacts in the specified version.
>>>>
>>>> Then unpack the shared libraries to a build folder, and make them
>>>> availble via the STUB_RUNTIME logic.
>>>>
>>>>
>>>> Plus an addition to the CONTRIBUTING.md documenting this.
>>>>
>>>>
>>>> I would be happy to help make and/or test the changes, but am only
>>>> able to work on Linux.
>>>>
>>>>
>>>> Thanks,
>>>> Jesper

[prev in list] [next in list] [prev in thread] [next in thread]