[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: [Rev 03] RFR: 8202296: Monocle MouseInput doesn't send keyboard modifiers in events.
From:       Kevin Rushforth <kcr () openjdk ! java ! net>
Date:       2020-04-28 22:38:55
Message-ID: IuIGv4ubZwQTs97FC8anxE_5I6BbrquE5x4dclxyFhw=.5675d63c-a91a-433a-bb02-db16e2c16630 () github ! com
[Download RAW message or body]

On Wed, 15 Apr 2020 08:28:22 GMT, Tom Schindl <tschindl@openjdk.org> wrote:

> > Extract keystate and add to the existing modifier mask, to support eg
> > multi-select
> > 
> > https://bugs.openjdk.java.net/browse/JDK-8202296
> 
> Tom Schindl has updated the pull request incrementally with one additional commit \
> since the last revision: 
> 8202296: Monocle MouseInput doesn't send keyboard modifiers in events.
> 
> Fix whitespace errors

Looks good to me. I verified that the new test fails without your fix and passes with \
your fix.

In case anyone else is looking at this and wants to run the test, it isn't enabled by \
default, so you need to run it like this:

gradle -PUNSTABLE_TEST=true -PFULL_TEST=true -PUSE_ROBOT=true \
    :systemTests:test --tests test.robot.com.sun.glass.ui.monocle.RobotTest

-------------

Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.java.net/jfx/pull/170


[prev in list] [next in list] [prev in thread] [next in thread]