[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8241999: ChoiceBox: incorrect toggle selected for uncontained
From:       Kevin Rushforth <kcr () openjdk ! java ! net>
Date:       2020-04-28 20:46:07
Message-ID: c6ROPfPJrRdidk4d1IHJyPPgaAvaNnTafEzapWBoTBQ=.4417a84c-b036-489c-a996-038e8e43916b () github ! com
[Download RAW message or body]

On Tue, 28 Apr 2020 15:36:53 GMT, Jeanette Winzenburg <fastegal@openjdk.org> wrote:

> The issue is that the toggles is not reliably unselected if an uncontained value is \
> set. 
> The root is ChoiceBoxSelectionModel which doesn't update the index on selecting an \
> uncontained item, in particular it fails to keep the invariant:
> assertEquals(getItems().indexOf(selectedItem), selectedIndex);
> 
> The fix here is to override select(item) to guarantee the assert.
> 
> Added/removed ignore from tests that failed before and pass after the fix. All \
> other tests are passing before and after.

@aghaisas can you review this? It looks pretty simple so one reviewer should be \
enough, unless you spot something where you want a second pair of eyes.

-------------

PR: https://git.openjdk.java.net/jfx/pull/200


[prev in list] [next in list] [prev in thread] [next in thread]