[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8242505: Some WebKit tests might fail because Microsoft libraries are not loaded
From:       Guru Hb <ghb () openjdk ! java ! net>
Date:       2020-04-28 15:13:39
Message-ID: 5IVeiuuZwgWO4pXCzrfgFVe0NmLagyrtMIEDyeV1o8c=.701acfef-b483-49d8-b09f-56f8d981e5bd () github ! com
[Download RAW message or body]

On Wed, 22 Apr 2020 18:07:09 GMT, Kevin Rushforth <kcr@openjdk.org> wrote:

> This PR will allow javafx.web unit tests to run to completion and pass on Windows \
> with Visual Studio 2019. 
> Two of the WebKit tests load the native WebKit library without initializing the \
> JavaFX runtime. This will lead to test failures and will hang the test run if those \
> tests are run before the other tests, and if the system doesn't have all the needed \
> runtime libraries.   The simple fix is to call the Toolkit method to load those \
> libraries. This is only needed for unit tests that don't already initialize the \
> JavaFX runtime (e.g., by calling `Platform::startup` or `Application::launch`) and \
> call internal methods that execute native code as part of the test.

Looks good to me

-------------

Marked as reviewed by ghb (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/194


[prev in list] [next in list] [prev in thread] [next in thread]