[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: Automate copyright year?
From:       Jeanette Winzenburg <fastegal () swingempire ! de>
Date:       2020-04-28 13:15:48
Message-ID: 20200428151548.Horde.ls_fUXe9L9lGOdfvDsvYZA1 () webmail ! df ! eu
[Download RAW message or body]



sounds good :)

Zitat von Kevin Rushforth <kevin.rushforth@oracle.com>:

>> Then we might decide not to request a change in review if only the
> copyright is not updated?
>
> Yes, this is a good idea. I don't generally flag this in my reviews,  
> for example. The exceptions would be: 1) if a new file springs to  
> life with the wrong initial copyright year; 2) if an incorrect  
> update was made to a copyright year.
>
> -- Kevin
>
>
> On 4/28/2020 4:18 AM, Jeanette Winzenburg wrote:
>>
>> Okay, thanks for the info :)
>>
>> Then we might decide not to request a change in review if only the  
>> copyright is not updated? If the second reviewers does it after the  
>> first already approved, the first has to re-approve - additional  
>> bureaucratic work and might lead to a bit of time lag across  
>> continents. Not such a big deal, but if it doesn't really matter ..
>>
>> -- Jeanette
>>
>> Zitat von Kevin Rushforth <kevin.rushforth@oracle.com>:
>>
>>> Not that I know of. FWIW, I'm not too bothered by this, since I  
>>> run a script 2-3 times a year to update the copyright years for  
>>> those files fixed in the current year.
>>>
>>> -- Kevin
>>>
>>>
>>> On 4/13/2020 3:48 AM, Jeanette Winzenburg wrote:
>>>>
>>>> Seeing that missing to update of copyright year in the header is  
>>>> rather common (in my own pull requests as well as in others :) is  
>>>> there any means to do so automatically or some source tool (for  
>>>> me that would be for Eclipse) that would do on request?
>>>>
>>>> -- Jeanette
>>>>
>>
>>
>>



[prev in list] [next in list] [prev in thread] [next in thread]